From c093eae9712e79cba958ab49457b4f2912fd95d7 Mon Sep 17 00:00:00 2001 From: N-R-K <79544946+N-R-K@users.noreply.github.com> Date: Wed, 22 Sep 2021 01:53:11 +0600 Subject: [PATCH] code-style: use constant length array (#79) currently the code-base doesn't make use of variable length array despite being -std=c99. it was irresponsible of me to introduce VLA in here. since this function will be called quite often, i did not want to make calls to malloc and free as they have some overhead. 512 should be sufficient enough and probably is far bigger than any window title bar can display anyways. --- window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/window.c b/window.c index 7e58a19..a8597d3 100644 --- a/window.c +++ b/window.c @@ -493,7 +493,7 @@ void win_draw_rect(win_t *win, int x, int y, int w, int h, bool fill, int lw, void win_set_title(win_t *win, const char *path) { - const unsigned int title_max = strlen(path) + strlen(options->title_prefix) + 1; + enum { title_max = 512 }; char title[title_max]; const char *basename = strrchr(path, '/') + 1;